Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests #2

Closed
stefanpenner opened this issue Feb 17, 2014 · 5 comments
Closed

tests #2

stefanpenner opened this issue Feb 17, 2014 · 5 comments

Comments

@stefanpenner
Copy link

Ember actually has a pretty nice testing story, we should make sure it is show-cased here

https://github.com/stefanpenner/ember-app-kit-todos/tree/master/tests might be a place to snoop around for ideas.

@manuelmitasch
Copy link
Owner

I do not have testing experience with Ember, but I can try. Anyway, I will not be able to work on this before the weekend. First, I need to finish my Ember talk and do some boring stuff.

@stefanpenner
Copy link
Author

understood, when you do have time, i'll gladly provide feedback and guidance

@manuelmitasch
Copy link
Owner

I have added some unit and acceptance tests. The testing store with EAK seems quite good. There are some problems, that I commented on the commits directly with your hash on it.

Other issue: Is there a sane way to (unit) test bound handlebars helpers?
Adding a testing route to the router seems to be very wrong to me:
https://github.com/stefanpenner/ember-app-kit/blob/2107e7e20aa4725aae03a66caf66962345cc0192/tests/acceptance/helper-test.js

Would love to hear your feedback!

@stefanpenner
Copy link
Author

@manuelmitasch open an issue on https://github.com/stefanpenner/ember-test-helpers/ regarding testing bound helpers, I'll make sure to add it.

@manuelmitasch
Copy link
Owner

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants