-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal attributes prevent build on .NET4.8 #13
Comments
Hi, I‘d like to help you, but I need more information to see where the problem lies since it’s working as intended in my local test projects. Could you either upload a sample C# project where the problem occurs or alternatively list the exact steps required to reproduce the error? Ideally both? Many thanks! |
Also, are you using a WPF Project? If so, could your issue be related to #11? |
Closing this for now since I cannot reproduce an error without more information. If the issue persits, please comment and provide further information. We can then reopen this issue. |
It was WPF framework but with new csproj format. I think making them public would solve the problem. I have public copies of the ones in a .net standard project I reference and it is fine. And it seems a .net core project also referencing that standard project has no conflict See in https://GitHub.com/mburbea/koar-item-editor There's a project KoAR.Core it is standard and has those attributes. The saveeditor is a wpf framework project and itemtesting is dotnetcore. No conflict and works fine |
Alright, thanks for the follow-up, much appreciated! Making the attributes public is not an option as there will 100% be conflicts in certain projects, especially libraries. If the attributes could be public, there would be no reason to provide this package in source-code form. Instead, we could just publish it as a .dll and call it a day. Nontheless, thanks again for reporting! |
I'm trying to decorate a method parameter with [AllowNull]. Inside the IDE, visual studio recognizes it and works fine, but when I go to compile the project I can not - it says the attribute is internal not public
The text was updated successfully, but these errors were encountered: