Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with download all button, Zip downloads appear to be broken every so often #3075

Open
ZoesDev opened this issue Oct 30, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ZoesDev
Copy link

ZoesDev commented Oct 30, 2024

Describe the bug
There seems to be a problem with the download all button. and doesnt appear to matter if the model has sub folders or not. as I was able to replicate it with a model with multiple files and multiple folders. the sometimes it appears it isnt waiting for the zip to be completed before it sends the download to the browser to download. I have attached a screenshot of what i mean, the 46.1MB zip is broken and the 283.1MB zip is working and able to extract.

this seems to be a sporadic issues but I am able to replicate it fairly constantly in at atleast 1 out of 4-6 downloads I create.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any model
  2. Click on download all or download STL files as I have been able to replicated it with that too.
  3. click on the zip and get an error sometimes if the zip is not the right size

Expected behavior
That the zip files would wait till its fully ready to go and then send to browser so that the zip files do not arrive broken. Probably future feature to have a status bar with this so we can see when it will be ready.

Screenshots
Screenshot 2024-10-30 at 2 19 06 PM

Screenshot 2024-10-30 at 2 17 11 PM

Desktop (please complete the following information):

  • OS: MacOS 15
  • Browser firefox
  • Version 132

Additional context
Not sure if this matters but my models are stored on a san with 100gbps connection to the server that runs the proxmox server that runs the vm for the containers I have on the server.

@ZoesDev ZoesDev added the bug Something isn't working label Oct 30, 2024
@Floppy
Copy link
Collaborator

Floppy commented Oct 31, 2024

@ZoesDev do you get both good and bad downloads from the same model? So it would seem to be very much related to the generation of the download, not the contents as such?

@ZoesDev
Copy link
Author

ZoesDev commented Oct 31, 2024

@Floppy that is exactly it. I can go to any model I have and if I click the download button I can get both zips you see. With time between each click.

I got to thinking maybe a smaller size model won’t have issues so will try that today and report back.

@Floppy
Copy link
Collaborator

Floppy commented Oct 31, 2024

OK thanks. I've tested the downloads on lots of models, but I probably haven't tried to open all of them. I'll test here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants