Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official integration #50

Open
OnFreund opened this issue Dec 8, 2022 · 7 comments
Open

Official integration #50

OnFreund opened this issue Dec 8, 2022 · 7 comments

Comments

@OnFreund
Copy link

OnFreund commented Dec 8, 2022

(originally started this as a discussion, but it doesn't look like discussions are active in this repo)

It seems like the new version is based on a JSON API, and does not employ any scraping like the old one.
Given this, would it be possible to create an official integration and try to merge it into the HA codebase?

@elad-bar
Copy link
Collaborator

elad-bar commented Dec 8, 2022

I think we should wait for the api to go official (end of the year), in addition, rename it to Read Your Meter Pro (as the company rebranded the solution) and then start talking about it,
Let keep discussing it in discord if you would like to

@OnFreund
Copy link
Author

OnFreund commented Dec 9, 2022

sure, what's your username on discord?

@elad-bar
Copy link
Collaborator

elad-bar commented Dec 9, 2022

In the discussion tab there is a link to the channel

@OnFreund
Copy link
Author

OnFreund commented Dec 9, 2022

You mean this one?
#46

It's expired

@OnFreund
Copy link
Author

@elad-bar is there an update link? thanks!

@elad-bar
Copy link
Collaborator

Updated it

@elad-bar
Copy link
Collaborator

Hi @OnFreund @maorcc
I conduct a major refactor to the component (v3.0.0), removed all the custom implementation to hide HA,
now the component is much lighter,
I also seperated the parts of communicating with RYMP API and added processors for account & meter to transform data into data model,
I think with that approach it would be much easier to complete the transtion into official component.

also simplified the functionality of reteriving and changing the alert settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants