Prevent signed overflow (UB) in SquirrelVM::GenerateUniqueKey()

z33ky · z33ky · commit 696036219e6d · 2024-11-13T00:25:51.000+01:00
diff --git a/sp/src/vscript/vscript_squirrel.cpp b/sp/src/vscript/vscript_squirrel.cpp
@@ -2776,7 +2776,7 @@ void* SquirrelVM::GetInstanceValue(HSCRIPT hInstance, ScriptClassDesc_t* pExpect
 
 bool SquirrelVM::GenerateUniqueKey(const char* pszRoot, char* pBuf, int nBufSize)
 {
-	static int keyIdx = 0;
+	static unsigned keyIdx = 0;
 	// This gets used for script scope, still confused why it needs to be inside IScriptVM
 	// is it just to be a compatible name for CreateScope?
 	V_snprintf(pBuf, nBufSize, "%08X_%s", ++keyIdx, pszRoot);

Original file line number	Diff line number	Diff line change
`@@ -2776,7 +2776,7 @@ void* SquirrelVM::GetInstanceValue(HSCRIPT hInstance, ScriptClassDesc_t* pExpect`
`2776`	`2776`
`2777`	`2777`	`bool SquirrelVM::GenerateUniqueKey(const char* pszRoot, char* pBuf, int nBufSize)`
`2778`	`2778`	`{`
`2779`		`- static int keyIdx = 0;`
	`2779`	`+ static unsigned keyIdx = 0;`
`2780`	`2780`	`// This gets used for script scope, still confused why it needs to be inside IScriptVM`
`2781`	`2781`	`// is it just to be a compatible name for CreateScope?`
`2782`	`2782`	`V_snprintf(pBuf, nBufSize, "%08X_%s", ++keyIdx, pszRoot);`