Have two words for "Layer"

[lucaswoj]

• Layers are things you define in a style
• Layers are also things in a datasource

Two concepts deserve two words

originally posted by @tmcw as mapbox/mapbox-gl-js#1237

cc @peterqliu @anandthakker @nickidlugash @jfirebaugh @mourner @ansis @springmeyer @yhahn @bhousel

[lucaswoj]

This is a complex issue.

Studio and the APIs currently use subset to refer to a "things in a datasource"

mapbox-gl-js, mapbox-gl-native, mapbox-gl-style-spec, exiting mapbox styles, and the vector tile spec use source-layer to "things in a datasource"

In my opinion, studio and the APIs should change to match the convention of calling "things in a datasource" source-layer. The "source" modifier is an acceptable differentiator between types of things.

[jfirebaugh]

Both things are called "layers" in their respective specifications.

• Vector tile layers
• Style layers

It's unlikely that we're going to rename either of these at the specification level, and I believe that introducing terms different than the underlying specification confuses, rather than clarifies, the issue. Let's use "source layer" and "style layer" where explicit disambiguation is necessary.

[tmcw]

cc @mapbox/appbox is this okay from a studio perspective, could we do a studio-wide rename?

[lyzidiamond]

I'm okay with source layer and style layer, so long as we are consistent.

[scothis]

is this okay from a studio perspective, could we do a studio-wide rename?

Doable. There are a couple tight places where we'll need to manually nudge the UI.

I'm okay with source layer and style layer, so long as we are consistent.

agreed