Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should high-level bindings always seize local refs? #32

Closed
jfirebaugh opened this issue Apr 13, 2018 · 0 comments
Closed

Should high-level bindings always seize local refs? #32

jfirebaugh opened this issue Apr 13, 2018 · 0 comments

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Apr 13, 2018 •
edited
Loading

In mapbox-gl-native, we're essentially manually seizing local refs whenever they are generated, in order to ensure that the local reference table never overflows. Djinni does the same thing.

Should the high-level bindings just always return jni::Local<T>s?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfirebaugh