You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now mapbox-base is a set of small submodules. That makes hard to support consistency between each small repo. Maybe we should place all these files in one repo? Like a std library.
As example, in VisionSDK we want to use optional and variant from mapbox-base and have a troubles:
optional class is placed inside std::experimental namespace, but variant places in mapbox::util one.
optional package have different structure from variant. variant have include/mapbox folder that allow me to add include folder to include_directories and use #include "mapbox/variant.hpp". But i can't do the same with optional. Because optional.hpp placed directly inside optional submodule directory
The text was updated successfully, but these errors were encountered:
Hi @deniskoronchik, I think what you're asking is the same that @pozdnyakov have been discussing: a single include header that contains aliases to the external header-only dependencies, something like this:
#include<external/optional.hpp>namespacemapbox {
namespacebase {
using optional = external::optional;
} // namespace base
} // namespace mapbox
Hi, I'm reading source code of mapbox-gl-native. Can anyone tell me what's the difference between mapbox::base::WeakPtr and std::weak_ptr? Are there any advantages of mapbox::base::WeakPtr over std::weak_ptr?
Right now
mapbox-base
is a set of small submodules. That makes hard to support consistency between each small repo. Maybe we should place all these files in one repo? Like a std library.As example, in VisionSDK we want to use
optional
andvariant
frommapbox-base
and have a troubles:optional
class is placed insidestd::experimental
namespace, but variant places inmapbox::util
one.optional
package have different structure fromvariant
.variant
haveinclude/mapbox
folder that allow me to add include folder toinclude_directories
and use#include "mapbox/variant.hpp"
. But i can't do the same withoptional
. Becauseoptional.hpp
placed directly insideoptional
submodule directoryThe text was updated successfully, but these errors were encountered: