Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM audit reports vulerabilities #1020

Closed
DDavidkov opened this issue Nov 3, 2020 · 0 comments · Fixed by #1052
Closed

NPM audit reports vulerabilities #1020

DDavidkov opened this issue Nov 3, 2020 · 0 comments · Fixed by #1052

Comments

@DDavidkov
Copy link

mapbox-gl-js version: 1.12.0 (but doesn't really matter)
mapbox-gl-draw version: 1.2.0

Steps to Trigger Behavior

  1. Init an npm repo using "npm init" and pressing "Enter" for all prompts
  2. Run "npm i @mapbox/mapbox-gl-draw"
  3. Run "npm audit"

Expected Behavior

0 vulnerabilities reported.

Actual Behavior

2 vulnerabilities reported:
mapbox-gl-draw-vulnerabilities

Additional info

Both vulnerabilities are caused by the minimist package using 1.2.0 version in which there is a low vulnerability. It is fixed in the newest version of minimist.

To fix the "@mapbox/mapbox-gl-draw > @mapbox/geojson-extent > @mapbox/geojson-coords > geojson-flatten > minimist" all you need to do is to bump the @mapbox/geojson-extent version to 1.0.0 and every library down the path is already updated to version without the vulnerability.

For the "@mapbox/mapbox-gl-draw > @mapbox/geojsonhint > minimist" path, @mapbox/geojsonhint has already updated the minimist version to a non-vulnerable version, but the change isn't released yet. There is an issue about that, but there is no activity since May of this year.

I know that this vulnerability can't really be exploited from the mapbox-draw-gl package, but my company has a blanket "no vulnerabilities" policy, so if you can update those packages, it will be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant