Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Style CONTEXT_LOST_WEBGL #13273

Closed
shuabrannigan opened this issue Sep 6, 2024 · 5 comments
Closed

Standard Style CONTEXT_LOST_WEBGL #13273

shuabrannigan opened this issue Sep 6, 2024 · 5 comments

Comments

@shuabrannigan
Copy link

mapbox-gl-js version: v3.5.2

browser: Chrome Version 128.0.6613.119 (Official Build) (arm64)

Steps to Trigger Behavior

  1. Load a map using the standard mapStyle mapbox://styles/mapbox/standard
  2. Add custom layers with filter applied
  3. Dynamically update the layer filter via map.setFilter(...)
  4. Interact with the map by zooming and panning

Link to Demonstration

jsbin

Expected Behavior

  • The layer filter should update correctly, and the map should reflect the new filter.
  • No WebGL context loss should occur, the map should function smoothly.

Actual Behavior

  • When updating the layer filter, the map loses WebGL context.
  • The map fails to render again, unless refreshed. (on multiple crashes webgl is disabled by the browser and requires a restart).

Additionally when i switch the style to mapbox://styles/mapbox/streets-v12 i do not run into this issue.

Screenshot 2024-09-06 at 12 10 15 pm

@stepankuzmin
Copy link
Contributor

Hi @shuabrannigan,

What OS are you using? I wasn't able to reproduce it on Google Chrome 128.0.6613.138 on macOS 14.6.1.

@shuabrannigan
Copy link
Author

shuabrannigan commented Sep 17, 2024

Hey @stepankuzmin

So i am running macOS 13.0.1 , i tried my jsbin again, and it happened as i described, however it did take longer to fail than previously here is a screen grab of the console on failure, hopefully helpful.

Screenshot 2024-09-17 at 1 06 45 pm

@stepankuzmin
Copy link
Contributor

Thanks for more details, @shuabrannigan. Could you please also try reproducing it with the latest v3.7.0-beta.1?

@shuabrannigan
Copy link
Author

@stepankuzmin okay here is an update, i did not lose context using that beta in my jsbin from the brief test I did. here is the updated code jsbin

i did get the following messages in the console

Screenshot 2024-09-18 at 8 01 49 am

but nothing killed the map, so issue seems resolved?

@stepankuzmin
Copy link
Contributor

Yeah, it appears that the root cause was fixed. The messages in the console are unrelated to the GL JS itself, so I'm considering this issue was fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants