Ignore "holes" in query*Features collision detection

[ansis]

Polygon holes don't need to be indexed:

mapbox-gl-js/js/data/feature_tree.js

Line 68 in 1582276

// TODO: skip holes when we start using vector tile spec 2.0

[mourner]

@ansis Can you clarify this — why would we ignore holes in polygons?

[ansis]

We don't need to index holes because the ring containing the hole is indexed. After looking up features in the index we use the actual geometry (including holes) to make sure the intersection is real.

But we should remove this comment. We can't (with v1 tiles) know whether something is a hole right now, and even then I don't think it would be significant.

[mourner]

We can't (with v1 tiles) know whether something is a hole right now

We can because we rely on v2 tiles since switching to Earcut. E.g. here https://github.com/mapbox/mapbox-gl-js/blob/master/src/util/classify_rings.js

[ansis]

Right, of course! I'd guess that skipping the hole is still not really worth it