-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to create StyleProperty class #2739
Labels
Comments
👍 -- what gl-native does might serve as a model here: |
This was referenced Nov 3, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many methods within
StyleLayer
that only operate on a single style property.setLayoutProperty
getLayoutProperty
getLayoutValue
setPaintProperty
getPaintProperty
getPaintValue
getPaintValueStopZoomLevels
getPaintInterpolationT
isPaintValueFeatureConstant
isLayoutValueFeatureConstant
isPaintValueZoomConstant
A cleaner design would be to have a
StyleProperty
object per property with all of these methodsAt the same time we might make
StyleTransition
conform to the same interface asStyleProperty
ref #2629 (comment)
The text was updated successfully, but these errors were encountered: