Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.27.0 broken in IE11 (Object doesn't support property or method 'fromCodePoint') #3606

Closed
oleksii-leonov opened this issue Nov 12, 2016 · 4 comments

Comments

@oleksii-leonov
Copy link

Looks like 0.27.0 broken in IE11:
screen shot 2016-11-12 at 17 56 15

Tested on IE11 (ver. 11.447.14393.0, Windows 10 with latest updates inside Parallels VM).
Edge, Chrome and other browsers on same VM works fine.

IE 11 console output:

SCRIPT438: Object doesn't support property or method 'fromCodePoint'
glyph_source.js (75,19)

screen shot 2016-11-12 at 18 08 54

mapbox-gl-js version: 0.27.0

Steps to Trigger Behavior

  1. Open https://www.mapbox.com/mapbox-gl-js/examples/ in IE11 (Win 10).

Expected Behavior

Map should loads successfully (or alert saying browser doesn't support Mapbox GL).

Actual Behavior

Map doesn't load (and no "doesn't support Mapbox GL" alert).

@oleksii-leonov
Copy link
Author

String.fromCodePoint() not supported by IE at all.
Also, it's not supported by Safari 9.

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/fromCodePoint

screen shot 2016-11-12 at 18 18 30

Same problem with String.codePointAt().

With next 2 small polyfills map start working fine in IE11:
https://github.com/mathiasbynens/String.fromCodePoint
https://github.com/mathiasbynens/String.prototype.codePointAt

@mourner
Copy link
Member

mourner commented Nov 14, 2016

Good catch! We should get 0.27.1 out with a fix. cc @lucaswoj @1ec5

@lucaswoj lucaswoj self-assigned this Nov 14, 2016
@jfirebaugh
Copy link
Contributor

Unfortunately, we won't be able to use those polyfills directly: mathiasbynens/String.fromCodePoint#4.

@1ec5
Copy link
Contributor

1ec5 commented Nov 16, 2016

We don’t actually need String.fromCodePoint(), do we? String.fromCharCode() is sufficient for the Basic Multilingual Plane, and we don’t support rendering anything in the astral planes (mapbox/DEPRECATED-mapbox-gl#29).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants