Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify worker of map removal #3652

Closed
jfirebaugh opened this issue Nov 17, 2016 · 2 comments
Closed

Notify worker of map removal #3652

jfirebaugh opened this issue Nov 17, 2016 · 2 comments
Labels
bug 🐞

Comments

@jfirebaugh
Copy link
Contributor

style._remove() should send a message to the worker, so that this.workerSources[mapId] and any other worker-side state is cleaned up.

#3602 (comment)
@asheemmamoowala
Copy link
Contributor

@arindam1993 Could this be related to the memory growth in #9126. Is this still an a problem?

@arindam1993
Copy link
Contributor

No, we terminate the workers so all resources are feed up automatically as a result.
But we should do something similar if we introduce an ability to control the worker pool externally of Map in our api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jfirebaugh @arindam1993 @anandthakker @asheemmamoowala