Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent step and interpolate expressions from having duplicate stops #4107

Closed
lucaswoj opened this issue Feb 1, 2017 · 2 comments
Closed

Prevent step and interpolate expressions from having duplicate stops #4107

lucaswoj opened this issue Feb 1, 2017 · 2 comments
Milestone
v0.42

Comments

@lucaswoj
Copy link
Contributor

lucaswoj commented Feb 1, 2017

From @scothis on February 5, 2016 22:51

Restore mapbox/mapbox-gl-style-spec#397 with a migration for existing ramps similar to mapbox/mapbox-gl-style-spec#411 for v9.

This behavior was merge in v8 and removed because it was backwards incompatible. The idea is sound and should be part of v9

Copied from original issue: mapbox/mapbox-gl-style-spec#414
@lucaswoj lucaswoj added the breaking change ⚠️ Requires a backwards-incompatible change to the API label Feb 1, 2017
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
@1ec5 1ec5 added the cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) label Feb 3, 2017
@jfirebaugh jfirebaugh mentioned this issue Mar 27, 2017
Closed
@jfirebaugh
Copy link
Contributor

We did this for expressions; for functions, we're more likely to just drop support for them entirely than make any other breaking change to them.

@jfirebaugh jfirebaugh mentioned this issue Oct 27, 2017
Closed
@jfirebaugh
Copy link
Contributor

We didn't actually do this for expressions, but we should.

@jfirebaugh jfirebaugh reopened this Nov 6, 2017
@jfirebaugh jfirebaugh added this to the v0.42 milestone Nov 6, 2017
@jfirebaugh jfirebaugh changed the title Prevent functions from having duplicate stops Prevent step and interpolate expressions from having duplicate stops Nov 6, 2017
@jfirebaugh jfirebaugh removed breaking change ⚠️ Requires a backwards-incompatible change to the API cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) labels Nov 6, 2017
@jfirebaugh jfirebaugh mentioned this issue Nov 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.42
Development

No branches or pull requests
3 participants
@jfirebaugh @lucaswoj @1ec5