-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarity around plugins contribution model #4260
Comments
There is no single type of plugin for GL JS. For example, there are plugins that add new UI elements, plugins that draw to The plugin contribution model is
I'd recommend the plugin exist as a function that turns a GeoJSON into a Mapbox Style
I'd recommend the plugin exist external to GL JS and call its methods.
I'd recommend the plugin exist as a function that turns a GeoJSON and some options into a Mapbox Style |
Have you seen https://github.com/mapbox/simplespec-to-gl-style? |
Thanks!
No I hadn't, thanks :)
Yeah, something like this:
where
Well, it needs to add a source to the map as well, so probably needs to be passed the map object, but yeah. |
I'd be interested in contributing a couple of Mapbox-GL-JS plugins, if Mapbox is accepting third-party plugins. But I can't see anything about what the contribution model is - what standard, if any, is required. The only blog post I see refers only to Control plugins.
A couple I had in mind (the basic work is already done):
The text was updated successfully, but these errors were encountered: