Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly evaluate enum-based identity functions #5023

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jul 21, 2017

Fixes #4999 (and simplifies existing enum-based property function integration tests).

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality

@lbud lbud changed the title 4999 identity enums Correctly evaluate enum-based identity functions Jul 21, 2017
@lbud lbud requested a review from anandthakker July 21, 2017 23:07
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lbud lbud merged commit 44c419a into master Jul 24, 2017
@lbud lbud deleted the 4999-identity-enums branch July 24, 2017 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants