Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big sprite maps overflowing the Uint8ClampedArray #5173

Closed
pwilczynski opened this issue Aug 19, 2017 · 2 comments
Closed

Big sprite maps overflowing the Uint8ClampedArray #5173

pwilczynski opened this issue Aug 19, 2017 · 2 comments

Comments

@pwilczynski
Copy link

In our application, users are able to re-style their icons. In the course of usage, therefore, a user may quickly overflow the sprite map. We've added icon reaping, which helps in some cases, but there's not much we can do when the user wants to have more icons than can be stored in the sprite map. Do you have any recommendations aside from forking Mapbox GL JS and changing it to a Uint16Array or otherwise increasing the size of the sprite map. Was Uint8Array chosen based on specifics of graphics card texture scaling, or was it just assumed to be a sufficient size?

@jfirebaugh
Copy link
Contributor

Hi @pwilczynski. Yes, this is a known issue described in #141, and we have work underway to address it in #4876. (Uint8Array vs Uint16Array isn't really the issue here -- it's the capacity of the sprite atlas, not the size of array elements, that needs to be increased.)

@pwilczynski
Copy link
Author

Hey @jfirebaugh thanks so much - we'll track #4876 and I'll make sure we take a look as that progresses. It's awesome to hear that you're working on this; we can't wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants