-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor texture-related classes #5277
Labels
Comments
6 tasks
Closing as outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#5101 introduced
RenderTexture
and #5190 introducedTexture
. There's also #4811, an older take on the same idea by @mourner, and existing code that uses texture-related WebGL calls directly without using either class.We should refactor and sort this out. Here's my proposed design:
gl::State<T>
and associated value traits.Texture
class. Internally, a property setter should:Texture
references as the value of uniforms, and having the internals handle assigning unique texture units, binding the textures, and setting the unit identifiers withglUniform*
.The text was updated successfully, but these errors were encountered: