-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise terminology for classifying expressions #5531
Comments
@1ec5 I'm having some trouble understanding this phrase. Could you clarify a bit more? |
Sure: you set |
I did struggle to find a neutral word to use here that would also be intuitive. I think "expression operator" is a good fit. |
Are |
This syntax doesn’t distinguish between binary and n-ary operators. I agree that |
We lack an unambiguous vocabulary for classifying expressions. The style specification says:
The wording “a specific expression” conflates the concept of an expression (an instance of the value that a paint/layout property or filter is set to) with the subset of expressions being described. Even “expression name” implies that “expression” is the entire subset of expressions. Meanwhile, the “Get started with Mapbox GL JS expressions” guide refers to “expression types”, which risks confusion with an expression’s evaluated data type.
Making matters worse, the style specification also describes a subset of expressions as “property expressions”. This term is supposed to refer to expressions that contain references to feature properties, but you set a paint or layout property to an expression whether or not the expression refers to a feature property.
I propose the following terminology:
get
operator somewhere withinzoom
operator somewhere within (with a nod to Rationalize and simplify the taxonomy of functions #4154)One thing going in favor of expression operator is that filters are classified by “operators” too.
/cc @mapbox/gl @colleenmcginnis
The text was updated successfully, but these errors were encountered: