Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Flow globals defined in interface files. #5643

Closed
vicapow opened this issue Nov 9, 2017 · 4 comments
Closed

Reduce Flow globals defined in interface files. #5643

vicapow opened this issue Nov 9, 2017 · 4 comments

Comments

@vicapow
Copy link
Contributor

vicapow commented Nov 9, 2017

Callback, Transferable, VectorTileFeature and likely others are types defined globally (this is the default for libdefs) but instead should instead of required explicitly. This is useful when using mapboxl-gl-js in other projects that may have conflicting global type name conflicts.

If I get some time, I'm happy to tackle this, but wanted to get feedback before I start.

Best,

@vicapow
Copy link
Contributor Author

vicapow commented Nov 12, 2017

Mind if I also merge the flow-typed/geojson.js file to geojson-types so it can be shared across projects?

@vicapow
Copy link
Contributor Author

vicapow commented Nov 12, 2017

Mind if I move the libdef of @mapbox/unitbezier to flow-typed project? Ditto for the rest of the module libdefs in the flow-typed folder.

@jfirebaugh
Copy link
Contributor

👍 on explicit requires. I'd prefer to keep the definitions locally controlled though. E.g. for the GeoJSON types, I reviewed several other modules, but none of them fit our needs exactly.

@vicapow
Copy link
Contributor Author

vicapow commented Nov 13, 2017

E.g. for the GeoJSON types, I reviewed several other modules, but none of them fit our needs exactly.

Makes sense. What if you creating a new repo, similar to geojson-types, that I could contribute to? I just want to use the same types across projects. I don't care so much who controls them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants