-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Flow globals defined in interface files. #5643
Comments
Mind if I also merge the |
Mind if I move the libdef of |
👍 on explicit requires. I'd prefer to keep the definitions locally controlled though. E.g. for the GeoJSON types, I reviewed several other modules, but none of them fit our needs exactly. |
Makes sense. What if you creating a new repo, similar to geojson-types, that I could contribute to? I just want to use the same types across projects. I don't care so much who controls them. |
Callback
,Transferable
,VectorTileFeature
and likely others are types defined globally (this is the default for libdefs) but instead should instead of required explicitly. This is useful when using mapboxl-gl-js in other projects that may have conflicting global type name conflicts.If I get some time, I'm happy to tackle this, but wanted to get feedback before I start.
Best,
The text was updated successfully, but these errors were encountered: