You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But, at render time, we don't scale the icon to match the text size at the current zoom level. For icon-text-size: both, we could solve this by disallowing the icon-size property to be set and just using the text-size data in the icon rendering pass.
I'm not sure what we should do to handle cases where icon-text-size is used in only one dimension, and icon-size is used for the other. Some permutations of this could be handled with an extra uniform, but, for example, {icon-text-size: 'width', icon-size: [... composite expression ...], text-size: [... another composite expression ...]} would entail providing additional vertex attribute data.
The text was updated successfully, but these errors were encountered:
Our current approach to
icon-text-fit
does not account for zoom-dependenttext-size
. We read the value oftext-size
during symbol layout:mapbox-gl-js/src/symbol/quads.js
Lines 72 to 92 in 5bebe1c
But, at render time, we don't scale the icon to match the text size at the current zoom level. For
icon-text-size: both
, we could solve this by disallowing theicon-size
property to be set and just using thetext-size
data in the icon rendering pass.I'm not sure what we should do to handle cases where
icon-text-size
is used in only one dimension, andicon-size
is used for the other. Some permutations of this could be handled with an extra uniform, but, for example,{icon-text-size: 'width', icon-size: [... composite expression ...], text-size: [... another composite expression ...]}
would entail providing additional vertex attribute data.The text was updated successfully, but these errors were encountered: