Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should hcl interpolation use shortest path? #5811

Closed
jfirebaugh opened this issue Dec 5, 2017 · 1 comment · Fixed by #5843
Closed

Should hcl interpolation use shortest path? #5811

jfirebaugh opened this issue Dec 5, 2017 · 1 comment · Fixed by #5843
Assignees
@jfirebaugh

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Dec 5, 2017 •
edited
Loading

Our current HCL interpolation implementation does a naive numeric interpolation of the hue value, which does not take the shortest path between hues:

image

I propose to change this so that the default is shortest path interpolation:

image
@jfirebaugh jfirebaugh mentioned this issue Dec 5, 2017
Closed
@stevage
Copy link
Contributor

stevage commented Dec 7, 2017 •
edited
Loading

Whoa, you mean the interpolation from 10 to 350 does the entire rainbow? Sounds pretty, but, um, not intuitive :) Definitely support that change.

@jfirebaugh jfirebaugh mentioned this issue Dec 11, 2017
Merged
@jfirebaugh jfirebaugh self-assigned this Dec 11, 2017
@jfirebaugh jfirebaugh mentioned this issue Dec 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfirebaugh jfirebaugh

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jfirebaugh @stevage