Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint performance regressed from 0.42.2 #5865

Closed
jfirebaugh opened this issue Dec 14, 2017 · 4 comments
Closed

Paint performance regressed from 0.42.2 #5865

jfirebaugh opened this issue Dec 14, 2017 · 4 comments
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage release blocker ⛔

Comments

@jfirebaugh
Copy link
Contributor

We need to recover this before releasing 0.43:

image

https://bl.ocks.org/anonymous/raw/3e1f39faef3155a250cda03b52b43e9e/

@averas
Copy link
Contributor

averas commented Dec 19, 2017

I am actually seeing a quite significant performance degradation already from 0.41.0 to 0.42.0 (and all releases after it).

In 0.41.0 zooming in and out over a quite dense vector tile layer is smooth:

0.41.0

Everything the same but switching to 0.42.0 (or 0.42.1 or 0.42.2):

0.42.0

There is an especially evident judder when passing whole number zoom levels as can be seen in the gif above. I also get tons of these in the console:

Which I don't get with 0.41.0...

Macbook Pro Late 2013
MacOS Sierra 10.12.6
Chrome Version 59.0.3071.115 (Official Build) (64-bit)

@averas
Copy link
Contributor

averas commented Dec 19, 2017

I created an example demonstrating the issue at https://codepen.io/anon/pen/YYwoKx
Change to 0.41.0 to see it work smoothly. I also realised that the difference between 0.41.0 and 0.42.x is not only the performance, but the visual rendering is quite different as well, both in the initial state and when zooming in/out.

@jfirebaugh
Copy link
Contributor Author

jfirebaugh commented Dec 19, 2017

Looks related to viewport collision detection. Since it isn't a regression from 0.42.2, could you please open a separate issue? Thanks!

@jfirebaugh
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage release blocker ⛔
Projects
None yet
Development

No branches or pull requests

2 participants