Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect result for isMoving() if drag/rotate and scroll interleave #6173

Closed
jfirebaugh opened this issue Feb 15, 2018 · 1 comment
Closed

Incorrect result for isMoving() if drag/rotate and scroll interleave #6173

jfirebaugh opened this issue Feb 15, 2018 · 1 comment
Assignees
@jfirebaugh
Labels
bug 🐞

Comments

@jfirebaugh
Copy link
Contributor

DragPanHandler, DragRotateHandler, and ScrollZoomHandler each set and unset map.moving independently. But zooms and drags can interleave:

  1. dragstart
  2. zoomstart
  3. zoomend
  4. dragend

In this scenario, map.isMoving() will return false between 3 and 4. It should return true.
@jfirebaugh
Copy link
Contributor Author

We should compute isMoving(), isZooming(), etc using handler isActive() methods rather than with additional (duplicate) state.

@jfirebaugh jfirebaugh mentioned this issue Feb 16, 2018
Merged
@jfirebaugh jfirebaugh self-assigned this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfirebaugh jfirebaugh

Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jfirebaugh