-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Expressions fully deserializable #6255
Labels
Comments
It would be great if we could use this as an opportunity to refactor/untangle the following types:
That seems like more types than is ideal. |
10 tasks
The performance considerations in #6367 suggest that we might want to solve this another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
CompoundExpression#_evaluate
doesn't survive serialization/deserialization via our web worker transfer scheme:mapbox-gl-js/src/util/web_worker_transfer.js
Line 101 in f87d7e3
This was fine until now, because we only evaluate a
{Source,Composite}Binder
's expression on the worker side, duringpopulatePaintArray
mapbox-gl-js/src/data/program_configuration.js
Line 139 in f87d7e3
For #6020, however, we'll need to evaluate again on the main thread when making updates, and so we should refactor
CompoundExpression
so that it can be fully rehydrated on the main thread.The text was updated successfully, but these errors were encountered: