Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that you can't add "attribution" property to a TileJSON-loaded vector source #6934

Closed
pathmapper opened this issue Jul 9, 2018 · 3 comments

Comments

@pathmapper
Copy link
Contributor

mapbox-gl-js version: v0.46.0

browser: Chrome on Linux

Link to Demonstration

https://jsbin.com/kivaqajija/edit?html,output

Expected Behavior

According to the style spec it should be possible to add an attribution property:

https://www.mapbox.com/mapbox-gl-js/style-spec#sources-vector-attribution

Actual Behavior

Error: a source with a "url" property may not include a "attribution" property

@pathmapper
Copy link
Contributor Author

The same for raster sources:
https://jsbin.com/caqenoxojo/edit?html,output

For raster-dem sources no error, but the attribution is not displayed:
https://jsbin.com/qiqoduheve/edit?html,output

@pathmapper
Copy link
Contributor Author

Just found #5936 (comment), so the error for vector and raster sources is expected behaviour.

I guess for raster-dem sources it's just missing.

It would be useful if the docs would mention that it is not possible to use some properties if providing a TileJSON resource with the url property.

@mourner mourner changed the title Error when adding "attribution" property to a vector source with "url" property Document that you can't add "attribution" property to a TileJSON-loaded vector source Jul 25, 2018
@asheemmamoowala
Copy link
Contributor

Closed by #8232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants