Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Style root level property "attribution" #6948

Open
pathmapper opened this issue Jul 11, 2018 · 0 comments
Open

Feature request: Style root level property "attribution" #6948

pathmapper opened this issue Jul 11, 2018 · 0 comments

Comments

@pathmapper
Copy link
Contributor

Motivation

Sometimes it is required to attribute a style different than the sources used in the style.

Design Alternatives

Design

Which design should we implement?
I favor a style root level property attribution.

What are the advantages of this design?
No need to use dummy sources (and dummy layers after #6281 is fixed).
It's possible to included the proper attribution in the style.
No need to pass a custom attribution string to the AttributionControl (if possible after #1485 is implemented).

What are some potential drawbacks of this design?
It's an addition to the style spec. Although such a property would be optional, maybe it affects also other implementers of the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants