Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdk-support entry for filter #7374

Closed
tristen opened this issue Oct 8, 2018 · 4 comments
Closed

Add sdk-support entry for filter #7374

tristen opened this issue Oct 8, 2018 · 4 comments

Comments

@tristen
Copy link
Member

tristen commented Oct 8, 2018

Motivation

The value for filter can be an expression but there isn't an entry for sdk-support in the style spec for it. Studio uses this information for compatibility and evaluating if expression supported UIs should be present. Can we document the sdk-support information for filter expressions?

@ansis
Copy link
Contributor

ansis commented Oct 12, 2018

from talking:

Expressions are available in filters whenever they are available elsewhere. So far support for expressions in features hasn't been tracked with sdk-support. Studio should use the way it determines support for expressions in properties to determine support for expressions in filters.

I think this means we don't have to add a sdk-support key here unless we add it everywhere. Should we add sdk-support for "expression"?

@tristen
Copy link
Member Author

tristen commented Oct 13, 2018

I think this means we don't have to add a sdk-support key here unless we add it everywhere. Should we add sdk-support for "expression"?

This happened with data-driven styling version entries but the same model wasn't applied for expressions. I can always account for this in my code, it just seemed odd at first there wasn't any compatibility data for filter values.

@mollymerp
Copy link
Contributor

Expressions are available in filters whenever they are available elsewhere.

Is this true? I think it isn't, at least for gl-native. Filter expression support was added by Lucas after the initial PR: mapbox/mapbox-gl-native#11251

@tristen
Copy link
Member Author

tristen commented Oct 23, 2018

I think I'm inclined to close this. There are compatibility entries for each expression and Studio should move off looking for this data from property names.

@tristen tristen closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants