Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FullscreenControl to specify a source #7544

Closed
carrieVant opened this issue Nov 2, 2018 · 0 comments · Fixed by #7548
Closed

Allow FullscreenControl to specify a source #7544

carrieVant opened this issue Nov 2, 2018 · 0 comments · Fixed by #7548

Comments

@carrieVant
Copy link

Motivation

There is currently no easy way to display additional features other than just the map in FullscreenControl. We display buttons below our map that allow users to toggle between different maps (ex: street, satellite) and add additional layers to maps that display/filter pins. We would like these to appear in Fullscreen view also.

Design Alternatives

Add a source property to FullscreenControl to specify which DOM element you would like to display in FullscreenControl. This would allow you to display an element that includes other functionality in FullscreenControl (similar to what OpenLayers.js currently supports).

Design

map.addControl(new mapboxgl.FullscreenControl({source: 'map-container'}));

Implementation

map.addControl(new mapboxgl.FullscreenControl({source: 'map-container'}));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants