Fullscreen control does not have a default tooltip when hovered

[dmytro-gokun]

Navigation controls do. For sure, it is possible to select the DOM element manually and assign the whatever tooltip we like. This, however, binds us to implementation details.

Another point here: if we want the tooltip to change based on the current _isFullscreen state, we have to catch corresponding events (e.g. repeat the browser-dependent code in our apps and maintain that as browsers change and progress). That does not look like a smart solution.

[andrewharvey]

This should be an easy change. Did you want to submit a PR?

This is how it sets the aria-label, but not title currently

mapbox-gl-js/src/ui/control/fullscreen_control.js

Line 90 in 361769f

button.setAttribute("aria-label", "Toggle fullscreen");

This is how it's done for navigation

mapbox-gl-js/src/ui/control/navigation_control.js

Line 93 in 361769f

a.title = ariaLabel;

[dmytro-gokun]

@andrewharvey Yep, I would like to try.

Question: do you think it makes sense to have different aria-babel/title based on the current "fullscreen" state. Something along these lines "Enter fullscreen mode"/"Exit fullscreen mode"? What do you think?

[andrewharvey]

Question: do you think it makes sense to have different aria-babel/title based on the current "fullscreen" state. Something along these lines "Enter fullscreen mode"/"Exit fullscreen mode"? What do you think?

Yes, after all, the icon is different based on enter/exit, so aria-label and title should have the same distinction.