You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
\n isn't in 0-255.pbf for this fontstack, which is fine, because it doesn't need to draw anything, and the actual line breaking is handled separately in the shaping. But whenever a tile gets reloaded, getGlyphs won't find the glyph here:
So it will re-request the entire range. This probably isn't a huge deal because the data should be cached, and it's not super-expensive to reload the PBF... but it's wasteful and it looks ugly in the network monitor (it grabbed my attention because if you have the cache disabled it looks like a major source of data traffic in maps that reload tiles frequently).
I don't think gl-native has the same issue since its glyph manager checks for already-loaded ranges instead of glyphs:
Consider the
format
expression demo:\n
isn't in0-255.pbf
for this fontstack, which is fine, because it doesn't need to draw anything, and the actual line breaking is handled separately in the shaping. But whenever a tile gets reloaded,getGlyphs
won't find the glyph here:mapbox-gl-js/src/render/glyph_manager.js
Lines 59 to 63 in c189971
So it will re-request the entire range. This probably isn't a huge deal because the data should be cached, and it's not super-expensive to reload the PBF... but it's wasteful and it looks ugly in the network monitor (it grabbed my attention because if you have the cache disabled it looks like a major source of data traffic in maps that reload tiles frequently).
I don't think gl-native has the same issue since its glyph manager checks for already-loaded ranges instead of glyphs:
https://github.com/mapbox/mapbox-gl-native/blob/096dea16e31c6e0d91eba0cab1ab2efc5d6ae853/src/mbgl/text/glyph_manager.cpp#L45-L52
cc @ryanhamley @asheemmamoowala
The text was updated successfully, but these errors were encountered: