-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues using a 1x1 icon for icon-text-fit
#8347
Comments
This will be fixed by #8741 |
@kkaefer has this made it into a version? I'm still seeing this issue when applying a 1px icon to labels to create underlines: |
Are you referring to the "blur"? If so, this is intended behavior since we're using linear scaling while the map is being zoomed/rotated. This will become the default state once #8738 lands so there's no switchover. 1×1 stretching icons without #8917 will continue to look like this. You can achieve the desired effect once #8917 lands, and then use a 3×1px icon with a stretch zone. |
@kkaefer I'm testing out the new stretchable icon feature and I'm seeing similar behaviour using this icon: default.svg.zip |
Icons being blurry while zooming is by design: when you're zooming, the position of the icon changes by fractional pixels (unlike when you're panning). so we decided to disable pixel grid snapping because otherwise they would appear to jiggle. |
I'm using a 1x1 icon that looks like this
on a layer that looks like this that uses the
icon-text-fit
property:I'm noticing a couple behaviours:
mapbox-gl-js version:
v1.0.0
browser:
Google Chrome Version 74.0.3729.169 (Official Build) (64-bit)
Expected behvaviour
For 1. I would expect the icon to fill the entire length of the label.
For 2. I would expect the icon to not blur and recalculate its size on
moveend
.Link to Demonstration
https://jsfiddle.net/e7gvdzLr/13/embedded/result/?username=tristen
The text was updated successfully, but these errors were encountered: