Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm dependency vunerability #8450

Closed
tholman opened this issue Jul 9, 2019 · 3 comments · Fixed by #8586
Closed

esm dependency vunerability #8450

tholman opened this issue Jul 9, 2019 · 3 comments · Fixed by #8586

Comments

@tholman
Copy link

tholman commented Jul 9, 2019

Getting some github alerts while using this lib due to "esm": "~3.0.84",

Screen Shot 2019-07-09 at 4 34 33 PM

Do you think you could give them a bump?

@mourner
Copy link
Member

mourner commented Jul 9, 2019

Not at the moment, since newer versions completely break our setup. However, you can safely dismiss this warning because it doesn't affect users of GL JS in any way. esm is only used by contributors for running tests.

@mourner mourner added needs investigation 🔍 Issues that require further research (e.g. it's not clear whether it's GL JS or something else) workflow 💅 labels Jul 9, 2019
@woodhull
Copy link

woodhull commented Jul 9, 2019

In that case, could esm be moved to a dev dependency?

@mourner
Copy link
Member

mourner commented Jul 10, 2019

Yes, we should probably do that. Previously it was moved for easier integration with mapbox-gl-native which reuses the GL JS shaders, but I think we can live with maintaining the same dependency there — it overweighs GitHub/NPM showing security warnings for projects using GL JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants