Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 6to5 #855

Closed
mourner opened this issue Dec 1, 2014 · 11 comments
Closed

Switch to 6to5 #855

mourner opened this issue Dec 1, 2014 · 11 comments
Assignees

Comments

@mourner
Copy link
Member

mourner commented Dec 1, 2014

https://github.com/mapbox/mapbox-gl-online/issues/558 — we should probably do this here too.

@tmcw
Copy link
Contributor

tmcw commented Dec 1, 2014

👍 this should be easy, will do now.

@jamiebuilds
Copy link

Hey @mourner and @tmcw, contributor to 6to5 here. If you need any help with this feel free to stop by our gitter room.

@mourner
Copy link
Member Author

mourner commented Dec 7, 2014

@thejameskyle sure, thanks for the friendly note :)

@tmcw
Copy link
Contributor

tmcw commented Dec 18, 2014

As discussed with @jfirebaugh, we're weighing pros/cons of switching back to es5 until io.js is a thing - tracebacks from es6 code running under node haven't been very accurate.

@jfirebaugh
Copy link
Contributor

Yeah, going to revert to es5. Tooling support for es6 in node is too premature.

@jfirebaugh
Copy link
Contributor

Also, to answer "why not io.js" -- it doesn't yet support the ES6 features we use (arrow functions and object literal extensions).

@mourner
Copy link
Member Author

mourner commented Jan 21, 2015

Yes, sounds good.

@jfirebaugh
Copy link
Contributor

Recording for posterity the reasons to switch back:

  • There are no node debuggers that understand source maps, so breakpoints etc. don't work correctly.
  • Couldn't get istanbul to work under traceur or 6to5.

@jamiebuilds
Copy link

Couldn't get istanbul to work under traceur or 6to5.

You can use isparta as your instrumentor and it should work fine.

@mourner
Copy link
Member Author

mourner commented Mar 20, 2015

@jfirebaugh
Copy link
Contributor

Yes. It's only for exception stack traces though, doesn't help with debugging or code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants