Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering of zoom control buttons on IE #8551

Closed
kbauhausness opened this issue Jul 25, 2019 · 1 comment
Closed

Flickering of zoom control buttons on IE #8551

kbauhausness opened this issue Jul 25, 2019 · 1 comment

Comments

@kbauhausness
Copy link
Contributor

mapbox-gl-js version: v54.0

browser: IE11

Steps to Trigger Behavior

  1. Load any style's share URL (like this one for Streets) in IE11 (I used browserstack), or initialize a map with GL JS including zoom control buttons
  2. zoom in and out, and note that the zoom control buttons will become grayed out sporadically at various zoom levels

@vallendm noted:

Looking into the history of the changes to navigation_control.js this change might have broken things
#8023

The change uses the classlist object ( https://developer.mozilla.org/en-US/docs/Web/API/Element/classList ) and uses the toggle function which is supported in IE since v10. But IE doesn't support the 2 argument version of the function the above PR uses. This results in the button switching state rather than updating to the correct state.

Link to Demonstration

see share URL above

Expected Behavior

zoom control buttons should be greyed out if the zoom is either at max/min

Actual Behavior

currently zoom control buttons can be greyed out at any zoom level and flicker as zoom level changes

cc @asheemmamoowala

@ryanhamley
Copy link
Contributor

This was fixed in #8495 and will be in the upcoming release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants