Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circle-sort-key/literal render test fails locally on macOS #8680

Closed
mourner opened this issue Aug 22, 2019 · 1 comment · Fixed by #8721
Closed

circle-sort-key/literal render test fails locally on macOS #8680

mourner opened this issue Aug 22, 2019 · 1 comment · Fixed by #8721

Comments

@mourner
Copy link
Member

mourner commented Aug 22, 2019

@ahk circle-sort-key/literal render test (introduced in #8467) fails for me locally, apparently because of some minor precision differences that make the debug line shift by 1 pixel:

image

@ahk could we remove debug: true from the test? Or maybe shift the center slightly to make it consistent across platforms?

@ahk
Copy link
Contributor

ahk commented Aug 23, 2019

Could it be helpful to just make the test pixel dimensions bigger? Ideally it's very obvious that cross-tile interaction is important in the test. Do you have any tips on how I can verify I made this test more robust?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants