Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE does not report render event after loaded event #8702

Closed
asheemmamoowala opened this issue Aug 28, 2019 · 1 comment · Fixed by #8708
Closed

IE does not report render event after loaded event #8702

asheemmamoowala opened this issue Aug 28, 2019 · 1 comment · Fixed by #8708

Comments

@asheemmamoowala
Copy link
Contributor

Moving forward from #8633 (comment)
@mannnick24 reported:

I believe there is now a race condition related to triggerRepaint in the map.render

in map.js is this
if (this._sourcesDirty || this._repaint || this._styleDirty || this._placementDirty) {
this.triggerRepaint();
} else if (!this.isMoving() && this.loaded()) {
this.fire(new Event('idle'));
}
and I think the tiles may not have loaded, but sourcesDirty could be false,

anyhoo, on IE we may or may not get a render after the map reports loaded() our product always waits for a a render with the map loaded (if dataloading) so our viz hangs in IE

Here is a fiddle, that may or may not trigger the fitbounds in IE - chrome seems to always pass
loadedrender.zip

Reproduction: https://jsbin.com/vovogurufe/edit?html,output

cc @kkaefer @kbauhausness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment