Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with promoteId definition in style spec #9204

Closed
samanpwbb opened this issue Jan 17, 2020 · 0 comments · Fixed by #9212
Closed

Problems with promoteId definition in style spec #9204

samanpwbb opened this issue Jan 17, 2020 · 0 comments · Fixed by #9212
Labels
bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) release blocker ⛔

Comments

@samanpwbb
Copy link
Contributor

samanpwbb commented Jan 17, 2020

mapbox-gl-style-spec version: 13.11.0-dev

browser: N/A


promoteId appears to be incorrectly applied to source types

The spec states that only source_geojson and source_raster_dem support promoteId.

I believe promoteId should be supported by either source_geojson or source_vector, and not source_raster_dem.

promoteId has an unclear type signature

The spec says, "Either a property name, or an object of the form {<sourceLayer>: <propertyName>}". Can we include an object type definition in the spec similar to how we do for sources (

"sources": {
"*": {
"type": "source",
"doc": "Specification of a data source. For vector and raster sources, either TileJSON or a URL to a TileJSON must be provided. For image and video sources, a URL must be provided. For GeoJSON sources, a URL or inline GeoJSON must be provided."
}
},
)? Right now there is no type specified, which makes it difficult to generate a UI for setting this property :)

Additionally, it isn't clear to me how to use the string form of this property. Would the string form only be used with geoJSON? Is there a way the spec can make that clear?

@samanpwbb samanpwbb added bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) labels Jan 17, 2020
@samanpwbb samanpwbb changed the title Problems with promoteId definition in in spec Problems with promoteId definition in style spec Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 cross-platform 📺 Requires coordination with Mapbox GL Native (style specification, rendering tests, etc.) release blocker ⛔
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants