Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'split' of undefined #25

Closed
ishitatsuyuki opened this issue Sep 21, 2018 · 2 comments · Fixed by #45
Closed

Cannot read property 'split' of undefined #25

ishitatsuyuki opened this issue Sep 21, 2018 · 2 comments · Fixed by #45
Labels

Comments

@ishitatsuyuki
Copy link

I'm getting multiple error reports from Sentry, which tracks down to the following line:

var parts = language.split('-');

All of them are reported from Chrome on Android, where the one with the newest version is running Chrome 62.

@andrewharvey
Copy link

I guess it should have a fallback that if it can't get navigator.languages, navigator.language or navigator.userLanguage it should just return null.

@andrewharvey
Copy link

BTW. I tested this on Chrome on Android, 69 and I can't replicate, but I still agree with being more defensive in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants