Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map panning broken in mapbox-gl 2.5 #145

Closed
agusterodin opened this issue Oct 16, 2021 · 5 comments
Closed

Map panning broken in mapbox-gl 2.5 #145

agusterodin opened this issue Oct 16, 2021 · 5 comments
Labels

Comments

@agusterodin
Copy link

I am experiencing insane map panning jitter that renders map unusable in mapbox-gl 2.5. I have tested with mapbox-gl 2.4.1 (latest 2.4 patch release) and it works fine. The bug was introduced with mapbox-gl 2.5.

Screen.Recording.2021-10-16.at.4.13.43.PM.mov

Thanks for the awesome library btw, much appreciated.

@SuperPat45
Copy link
Contributor

Same bug with mapbox-gl version 1.15.2

@mourner mourner added the bug label Oct 22, 2021
@rreusser
Copy link

rreusser commented Oct 25, 2021

I'm having a tricky time determining exactly how it results in the issue, but can confirm that these are the lines, the removal of which is responsible for the issue:

https://github.com/mapbox/mapbox-gl-js/pull/11084/files#diff-674b3f5df7dce0a867437ddbfcf8b0b6d08546903d4b19f70273e55a8ff2114eL347-L351

It should be implementing this blur on the individual handlers so that desktop interactions are blurred while touch interactions are not, but I wonder if the decision of which handlers on which to implement custom blur handlers is not quite right—in addition to the bigger question of why it's the blur handler that ultimately causes the issue.

@manuelroth
Copy link

Hi @rreusser, I just found this issue here because I ran into the same problem. Would it be possible to implement a workaround for this issue in mapbox-gl-leaflet?- Or this is need to be changed in mapbox-gl-js?

@weca-theo
Copy link

Can confirm this fix is working:
#155

@jgravois
Copy link
Collaborator

jgravois commented Jun 6, 2023

fixed by @denisones in v.0.0.16

@jgravois jgravois closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants