Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Port circle-sort-key #197

Closed
tobrun opened this issue Feb 25, 2020 · 3 comments · Fixed by #322
Closed

Port circle-sort-key #197

tobrun opened this issue Feb 25, 2020 · 3 comments · Fixed by #322
Assignees

Comments

@tobrun
Copy link
Member

tobrun commented Feb 25, 2020

We already have symbol sort keys but now circle/line as well:

@chloekraw chloekraw changed the title *-sort-key Port circle-sort-key Mar 31, 2020
@chloekraw
Copy link
Contributor

chloekraw commented Apr 7, 2020

👋 looking at the changes needed for line- and fill-sort-key bindings, I'm interested in pairing with someone on this one after the JNI work is done (and once the core implementation lands).

The changes needed look fairly straightforward from what I can see: the main work would be on CircleLayer.java and PropertyFactory.java, followed by adding tests. I think this would be a great experience for me to learn more about how to add tests to our SDK when we're implementing new features.

@Chaoba
Copy link
Contributor

Chaoba commented Apr 7, 2020

@chloekraw These changes are made by a script.

If cycle-sort-key is ready in gl-native, we just need comment out this line and run the command make android-style-code all changes will be generated automatically.

@chloekraw
Copy link
Contributor

@Chaoba oh wow, that's so cool!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants