Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

testContentInsetCenter & testContentInsetOrnaments fail on iPhone X #167

Closed
julianrex opened this issue Feb 18, 2020 · 2 comments · Fixed by #420
Closed

testContentInsetCenter & testContentInsetOrnaments fail on iPhone X #167

julianrex opened this issue Feb 18, 2020 · 2 comments · Fixed by #420
Assignees
@fabian-guerra
Labels
bug Something isn't working tests

Comments

@julianrex
Copy link
Contributor

julianrex commented Feb 18, 2020 •
edited
Loading

The following unit tests are failing on an iPhone X simulator in release-unicorn:

  • testContentInsetCenter
    At first glance, this appears to be an assumption in the test, that the top and bottom content insets are equal.

  • testContentInsetOrnaments
    Although contentInset is set to 0, automaticallyAdjustsContentInset is YES, so will be reset to the safe insets (IIRC). However, even if this is set to NO the ornament constraints are still relative to the safe insets.

EDIT: Worth noting that these tests pass on an iPhone 8, which happens to be the device used in CI, hence why we haven't seen this fail PRs.

/cc @fabian-guerra @astojilj
@julianrex julianrex added bug Something isn't working tests labels Feb 18, 2020
@julianrex
Copy link
Contributor Author

cc @jmkiley

@1ec5 1ec5 mentioned this issue Apr 30, 2020
Closed
@1ec5
Copy link
Contributor

1ec5 commented Apr 30, 2020

This issue reproduces in the wild: mapbox/mapbox-navigation-ios#2353.

@fabian-guerra fabian-guerra reopened this Sep 4, 2020
@fabian-guerra fabian-guerra mentioned this issue Sep 4, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fabian-guerra fabian-guerra

Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
3 participants
@1ec5 @fabian-guerra @julianrex