Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

iOS/macOS reusable snapshotter #10038

Closed
fabian-guerra opened this issue Sep 21, 2017 · 0 comments
Closed

iOS/macOS reusable snapshotter #10038

fabian-guerra opened this issue Sep 21, 2017 · 0 comments
Assignees
Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS

Comments

@fabian-guerra
Copy link
Contributor

The current status of MBGLSnapshotter does not allow full reuse.

In a chat with @frederoni he confirmed:

It can be reused but the associated MGLMapCamera is transformed to mbgl::CameraOptions upon initializing so pretty much every case you want to reuse it won’t work.

Imagine using a snapshotter when you scroll through a table view.

  • cellWillDisappear/prepareForReuse should cancel the snapshotter
  • but you can’t reuse because the camera is already set. (you can reuse but the region will most likely not be the same)

In order to make it reusable it will require move MGLMapSnapshotOptions to a setter which is an easy task.
The questions would be if it's valuable for developers have a reusable snapshotter and which would be the uses cases for it.

/cc @1ec5 @frederoni @boundsj

@fabian-guerra fabian-guerra added feature iOS Mapbox Maps SDK for iOS labels Sep 21, 2017
@fabian-guerra fabian-guerra self-assigned this Sep 21, 2017
@1ec5 1ec5 added the macOS Mapbox Maps SDK for macOS label Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

No branches or pull requests

2 participants