Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Simplify and consolidate Shape sources #10410

Open
asheemmamoowala opened this issue Nov 8, 2017 · 3 comments
Open

Simplify and consolidate Shape sources #10410

asheemmamoowala opened this issue Nov 8, 2017 · 3 comments
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling SEMVER-MAJOR Requires a major release according to Semantic Versioning rules

Comments

@asheemmamoowala
Copy link
Contributor

In #9983 and previous tickets, there has been much discussion over the naming and convention around MGLComputedShapeSource and its related classes.

Previous conversations have centered around:

  • Removing MGLAbstractShapeSource in favor of a single MGLShapeSource that allows providing the shape content in a single call, or via callbacks. #9983(comment)
  • Improving the API interface for MGLComputedShapeSourceDataSource to better indicate that it will not be called on the main thread, and should be implemented with thread safety in mind.1, 2, and 3
  • Simplifying MGLShapeSourceOption, and better align it with the specific options of the shape source being used.

cc @1ec5

@asheemmamoowala asheemmamoowala added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Nov 8, 2017
@1ec5
Copy link
Contributor

1ec5 commented Nov 8, 2017

iOS SDK v4.0.0 may be our last opportunity to implement any of these options for awhile, since v5.0.0 would presumably be further down the road.

/cc @lilykaiser

@lilykaiser lilykaiser added the SEMVER-MAJOR Requires a major release according to Semantic Versioning rules label Jan 23, 2018
@1ec5
Copy link
Contributor

1ec5 commented Feb 14, 2018

#10853 may be a way to pare back this work to something manageable in the v4.0.0 timeframe.

@1ec5
Copy link
Contributor

1ec5 commented Apr 2, 2018

#11568 removed MGLAbstractShapeSource, but it left separate MGLShapeSource and MGLComputedShapeSource classes. A future unification – or at least making one a subclass of the other – would be desirable, but any changes along these lines would require refactoring the underlying mbgl classes as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor runtime styling SEMVER-MAJOR Requires a major release according to Semantic Versioning rules
Projects
None yet
Development

No branches or pull requests

3 participants