Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

getStyle().addImage() can halt the map from rendering #10526

Closed
tobrun opened this issue Nov 22, 2017 · 3 comments
Closed

getStyle().addImage() can halt the map from rendering #10526

tobrun opened this issue Nov 22, 2017 · 3 comments
Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl

Comments

@tobrun
Copy link
Member

tobrun commented Nov 22, 2017

Capturing from #10517 that getStyle().addImage() can result in momentary halting the map (while looping and adding 500 images). While it isn't noticeable during initialisation:

ezgif com-video-to-gif 5

It's noticeable when delaying the addImage invocation:

ezgif com-video-to-gif 8

@tobrun tobrun added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl labels Nov 22, 2017
@nikiizvorski
Copy link

For me both addImages() and addImage() does that in a slightly difference matter. One is a bit bette than the other one which we already know why.

@nikiizvorski
Copy link

@tobrun Hey Tobrun i am not trying to affect and i am trying to be constructive here. What i was speaking is that your solution doesn't solve the problem. We already know that thats possible i am doing it currently. And with yours i will give you the example you have you have loaded 500 but small bitmaps less than 1kb which are not coming from objects and they are created and staying in ObjectPool of the Bitmap. And after they are being reused so thats why you don't have the existing problem. Please get in depth with this one to create the same problem. But we try to rethink our strategy since you shouldn't load more than a couple projects with Lazy Load. I already did all whats possible with the API that you have i just want to check if other people did something that i didn't currently see.

@jfirebaugh
Copy link
Contributor

Duplicate of #10249?

@tobrun tobrun closed this as completed Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

No branches or pull requests

3 participants