Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Java Peer RasterDEMSource missing #11025

Closed
femski opened this issue Jan 24, 2018 · 4 comments · Fixed by #11031
Closed

Java Peer RasterDEMSource missing #11025

femski opened this issue Jan 24, 2018 · 4 comments · Fixed by #11031
Labels
Android Mapbox Maps SDK for Android beta blocker Blocks the next beta release

Comments

@femski
Copy link

femski commented Jan 24, 2018

Platform:
Android

Mapbox SDK version:
Master Branch

Steps to trigger behavior

Add a new layer of type HillshadeLayer

Expected behavior

Brilliant new HillshadeLayer layer

Actual behavior

Crash

Probable cause: Java Peer RasterDEMSource is not defined so I don't see a way to add DEM layer right now. If you just add normal RASTER layer (RGB terrain) it still leads to segmentation fault in:

line 97: mapbox-gl-native/src/mbgl/renderer/layers/render_hillshade_layer.cpp
assert(dynamic_cast<HillshadeBucket*>(tile.tile.getBucket(*baseImpl)));

Thank you for looking.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jan 24, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Jan 24, 2018
@tobrun tobrun added the beta blocker Blocks the next beta release label Jan 24, 2018
@tobrun
Copy link
Member

tobrun commented Jan 24, 2018

@femski you are correct, while layers are automatically generated as part of the style spec code generation, sources as RasterDEMSource aren't and these need to be manually added. I will look into adding integration of RasterDEMSource on the Android binding.

cc @mollymerp

@tobrun tobrun removed the beta blocker Blocks the next beta release label Jan 24, 2018
@femski
Copy link
Author

femski commented Jan 24, 2018

Similar to #10991

@kkaefer
Copy link
Member

kkaefer commented Jan 24, 2018

/cc @mollymerp

@tobrun
Copy link
Member

tobrun commented Jan 25, 2018

#11031 resolves this issue by adding the RasterDEMSource integration and an example, once merged you can retest with the 6.0.0-SNAPSHOT or master branch. Thank you for reporting this @femski.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android beta blocker Blocks the next beta release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants