Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add heatmap-color support on Android #11172

Closed
tobrun opened this issue Feb 12, 2018 · 6 comments
Closed

Add heatmap-color support on Android #11172

tobrun opened this issue Feb 12, 2018 · 6 comments
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS release blocker Blocks the next final release runtime styling

Comments

@tobrun
Copy link
Member

tobrun commented Feb 12, 2018

Capturing from @mourner in #11046 (comment):

I disabled any code generation for heatmap-color on the Android side because it requires being able to pass expressions as its values — as far as I remember, we had some bits missing about expressions which made it very hard to make it work.

Ticketing this out so we don't forget adding this for the final release.

@tobrun tobrun added Android Mapbox Maps SDK for Android release blocker Blocks the next final release labels Feb 12, 2018
@tobrun tobrun added this to the android-v6.0.0 milestone Feb 12, 2018
@tobrun tobrun mentioned this issue Feb 12, 2018
14 tasks
@1ec5 1ec5 added GL JS parity For feature parity with Mapbox GL JS runtime styling labels Feb 12, 2018
@tobrun
Copy link
Member Author

tobrun commented Feb 12, 2018

I reenabled generating the heatmap-color property from the specification and I'm hitting:

screen shot 2018-02-12 at 20 03 32

update: the reason why the system can't handle automatic conversion:

// from paint_property.hpp

/*
 * Special-case paint property traits for heatmap-color, needed because
 * heatmap-color values do not fit into the
 * Undefined | Value | {Camera,Source,Composite}Function taxonomy that applies
 * to all other paint properties.
 *
 * These traits are provided here--despite the fact that heatmap-color
 * is not used like other paint properties--to allow the parameter-pack-based
 * batch evaluation of paint properties to compile properly.
 */

we need a conversion to support this special property.

@mourner
Copy link
Member

mourner commented Feb 13, 2018

@tobrun I recall that we were not able to convert properly at the time of the PR, but @anandthakker @ChrisLoer might be working on this now, or at least expect to land some improvements soon — can you comment?

@ChrisLoer
Copy link
Contributor

@mourner we're close to landing an Expression::serialize() that returns an mbgl::Value is that what you'd need?

@tobrun
Copy link
Member Author

tobrun commented Feb 14, 2018

@ChrisLoer awesome to hear, that would make integration from my end a lot easier

@anandthakker
Copy link
Contributor

@tobrun yeah, I think this needs the equivalent of #11074

@tobrun
Copy link
Member Author

tobrun commented Mar 2, 2018

fixed with #11220, getter will be added with #11352

@tobrun tobrun closed this as completed Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android GL JS parity For feature parity with Mapbox GL JS release blocker Blocks the next final release runtime styling
Projects
None yet
Development

No branches or pull requests

5 participants