cameraThatFitsShape should accept target pitch as well

[bsudekum]

mapbox-gl-native/platform/macos/src/MGLMapView.mm

Lines 1275 to 1296 in 6fa57b7

	- (MGLMapCamera *)cameraThatFitsShape:(MGLShape *)shape direction:(CLLocationDirection)direction edgePadding:(NSEdgeInsets)insets {
	mbgl::EdgeInsets padding = MGLEdgeInsetsFromNSEdgeInsets(insets);
	padding += MGLEdgeInsetsFromNSEdgeInsets(self.contentInsets);
	mbgl::CameraOptions cameraOptions = _mbglMap->cameraForGeometry([shape geometryObject], padding, direction);
	return [self cameraForCameraOptions:cameraOptions];
	}
	- (MGLMapCamera *)cameraForCameraOptions:(const mbgl::CameraOptions &)cameraOptions {
	CLLocationCoordinate2D centerCoordinate = MGLLocationCoordinate2DFromLatLng(cameraOptions.center ? *cameraOptions.center : _mbglMap->getLatLng());
	double zoomLevel = cameraOptions.zoom ? *cameraOptions.zoom : self.zoomLevel;
	CLLocationDirection direction = cameraOptions.angle ? mbgl::util::wrap(-MGLDegreesFromRadians(*cameraOptions.angle), 0., 360.) : self.direction;
	CGFloat pitch = cameraOptions.pitch ? MGLDegreesFromRadians(*cameraOptions.pitch) : _mbglMap->getPitch();
	CLLocationDistance altitude = MGLAltitudeForZoomLevel(zoomLevel, pitch,
	centerCoordinate.latitude,
	self.frame.size);
	return [MGLMapCamera cameraLookingAtCenterCoordinate:centerCoordinate
	fromDistance:altitude
	pitch:pitch
	heading:direction];
	}

Since the target pitch of the resulting camera is not exposed, internally we're looking at the pitch of the current map view when calculating the resulting camera.

The addition of another argument (pitch) would allow users to go from a pitched view to unpitched view in one fluid motion.

/cc @asheemmamoowala @frederoni @1ec5

[1ec5]

Duplicate of #10115.