Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove Expression input option for unsupported properties #11790

Closed
LukasPaczos opened this issue Apr 27, 2018 · 2 comments
Closed

Remove Expression input option for unsupported properties #11790

LukasPaczos opened this issue Apr 27, 2018 · 2 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@LukasPaczos
Copy link
Member

A lot of style properties do not support data-driven-styling and therefore expressions input shouldn't be available for those properties.
Trying to use Expression with such property results in a jni::PendingJavaException.

@LukasPaczos
Copy link
Member Author

Noting, that with #11960 we'll be able to use literal expression with non-dds properties.

@LukasPaczos
Copy link
Member Author

Actually, #11960 together with #12018 fix crashes regarding wrong Expression input, which were caused by the wrong literal parsing.

Now, when a data-driven Expression is used with a property that doesn't support dds, an error is logged:

Error setting property: icon-allow-overlap property expressions not supported

which should be a sufficient hint about next actions.

Noting, that non-dds properties still support all constant and zoom expressions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

2 participants